search

SAP / open-ux-odata

Enable community collaboration to jointly promote and facilitate best in class framework and tooling capabilities when working with OData services.
Apache License 2.0
51 stars 13 forks source link

chore: suggestions #856

Closed marianfoo closed 1 week ago

marianfoo commented 2 months ago

Some suggestions, please create a discussion if you need more info

I also created a quick sample for using tenants, for a customer i developed the generic usage of a base.js (the naming is maybe confusing with the base api).

I make it draft because this is not intended to be merged

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 4fa443d5616cea0f88bbbb959dc41836ad5dd280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nlunets commented 2 months ago

Thanks for this nice starting point, I think we can improve the docu there, and i'll look into making the tenant specific mockdata thing part of the builtin functionality

marianfoo commented 2 months ago

What should we do with the PR? Should i create a different PR for the tenants sample that we can merge when your feature is ready or do you want to create your own sample? We can use this PR only for the documentation

nlunets commented 2 months ago

If you can create a different PR with the sample feature i'll just use that as a base for the auto loading of data :) And we keep this one for docu yes

marianfoo commented 2 months ago

If you can create a different PR with the sample feature i'll just use that as a base for the auto loading of data :) And we keep this one for docu yes

created here https://github.com/SAP/open-ux-odata/pull/859

nlunets commented 1 week ago

Readme specific update are covered in https://github.com/SAP/open-ux-odata/pull/888

nlunets commented 1 week ago

Thanks @marianfoo i also Included the change to the config syntax in the other change so this one is good to goaway

marianfoo commented 1 week ago

Thanks!