BUG - Incorrect message shown for ABAP deployment when using a URL

Related Feature

Feature request: issue number

Description

When using the following ui5-deploy.yaml configuration;

  customTasks:
    - name: deploy-to-abap
      afterTask: generateCachebusterInfo
      configuration:
        strictSsl: false
        target:
          url: http://myinternal-host:50000
        app:
          name: ZE2EWRKLTEC1
          description: My Deployed Worklist V2 App
          package: $TMP
          transport: ""
        exclude:
          - /test/

A timeout is handled and the following message is outputted;

info abap-deploy-task ZE2EWRKLTEC1 ZE2EWRKLTEC1 found on target system: false
warn abap-deploy-task ZE2EWRKLTEC1 Warning: The application was deployed despite a time out response from the backend. Increasing the value of the HTML5.Timeout property for the destination may solve the issue

The HTML5.Timeout is not applicable here since there is no reference to any destination.

Steps to Reproduce

Steps to reproduce the behavior:

Generate a Fiori UI app
Deploy the application

Expected results

Error message does not include the HTML5.Timeout string.

Actual results

HTML5.Timeout is shown but a destination was not used to deploy.

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here OS:

[ ] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

--- Update - this has been fixed already in a different PR

Another issue found with logging is around showing the following full url when a message is returned from the ABAP backend;

info abap-deploy-task MyApp Please copy/paste this URL in a browser for more details:
info abap-deploy-task MyApp http://my-abap-endppint:443/sap/opu/odata/iwbep/message_text;o=LOCAL/

This is using the following destination properties;

{
    "Name": "myabapendppint",
    "Type": "HTTP",
    "Authentication": "PrincipalPropagation",
    "ProxyType": "OnPremise",
    "HTML5.DynamicDestination": "true",
    "CloudConnectorLocationId": "CloudId",
    "HTML5.Timeout": "60000",
    "WebIDEEnabled": "true",
    "sap-client": "200",
    "WebIDEUsage": "odata_abap,dev_abap",
    "Host": "http://my-abap-endppint:443/"
}

The log is showing the virtual host URL which will not work unless a customer replaces the virtual host with the internal host which is configured in the SAP cloud connector. This is not always obvious to the enduser and should be updated.

SAP / open-ux-tools