search

SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
83 stars 39 forks source link

BUG - Invalid manifest datasource key created #1248

Open unseen1980 opened 1 year ago

unseen1980 commented 1 year ago

Description

The generator is using the datasource as a key name in the manifest. In some cases this leads to an invalid property name, if the datasource contains forward slashes.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Generate a Fiori elements application on BAS using E.g. Y05 with data source /DMO/UI_FLIGHT_R_V2_VAN
  2. Open the generated manifest.json file.
  3. Navigate the dataSources section.
  4. Observe the error.

Expected results

The dataSource key name is valid.

Actual results

The data source key name is not valid, see https://github.com/SAP/ui5-manifest/blob/master/schema.json#L349 for the valid regex.

tobiasqueck commented 1 year ago

@unseen1980 has this been fixed with the referenced PRs or is it still open?