SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
83 stars 41 forks source link

BUG - Uaa credentials not being referenced during ABAP deployment flow #1290

Closed longieirl closed 1 year ago

longieirl commented 1 year ago

Related Feature

Related to https://github.com/SAP/open-ux-tools/pull/982

Description

When executing the following CLI command;

npx fiori deploy --verbose --url https://my-abap-backend.hanavlab.ondemand.com --name MyApp --package MyPackage --transport MyTransport --archive-path archive.zip --uaa-url https://my-abap.authentication.sap.hana.ondemand.com --uaa-username **** --uaa-password **** --uaa-clientid **** --uaa-clientsecret **** --strict-ssl --noConfig --yes --failfast

an exception is thrown and the user is unable to deploy the Fiori UI app;

info    abap-deploy-task: Starting to deploy. 16:23:13  node:events:49116:23:13        throw er; // Unhandled 'error' event16:23:13        ^16:23:13  
Error: spawn xdg-open ENOENT

Steps to Reproduce

Steps to reproduce the behavior:

  1. Generate a Fiori UI archive.zip file
  2. Run the CLI command as shown above

Expected results

Fiori UI application is deployed.

Actual results

Exception is thrown and user is blocked from deloying.

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here OS:

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

longieirl commented 1 year ago

Fixed in latest version of ui5-tooling.