search

SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
82 stars 33 forks source link

[Feature] Disable Control Property Editor for ADP projects with UI5 version lower than 1.71 #1405

Closed GDamyanov closed 4 weeks ago

GDamyanov commented 8 months ago

As a developer, I want to disable the CPE for ADP projects with ui5 version lower than 1.71, so that I cannot open CPE

Description

Control Property Editor should be disabled for ADP projects with UI5 version (set in the ui5.yaml in ui5-proxy-middleware) lower than 1.71

Technical Design

Acceptance Criteria

GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)

Given I have a ADP project with UI5 version lower than 1.71 set in ui5.yaml in the ui5-proxy-middleware when I start the Control Property Editor then I should see error message with text "The current SAPUI5 version set for this Adaptation project is {some version}. The minimum version to use for SAPUI5 Adaptation Project and its SAPUI5 Visual Editor is 1.71" and a new browser tab with Control Property Editor should not be loaded.

Notes

Tasks

tobiasqueck commented 8 months ago

@GDamyanov what should happen in such case? Should an error be shown or ... ? Should the preview without CPE work?

GDamyanov commented 8 months ago

@GDamyanov what should happen in such case? Should an error be shown or ... ? Should the preview without CPE work?

Error message should be shown in the console and the CPE should not be loaded.

tobiasqueck commented 8 months ago

Error message should be shown in the console and the CPE should not be loaded.

Your implementation in #1423 is preventing also the preview (no editor). Is this also the goal or should the plain preview work?

GDamyanov commented 8 months ago

Error message should be shown in the console and the CPE should not be loaded.

Your implementation in #1423 is preventing also the preview (no editor). Is this also the goal or should the plain preview work?

The preview should also be stopped.