SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
83 stars 35 forks source link

TBI - update @sap-ux/fiori-freestyle-writer #1989

Closed mikicvi-SAP closed 3 months ago

mikicvi-SAP commented 3 months ago

Description (include screenshots)

Sometime ago the @sap-ux/fiori-elements-writer was updated(internal ticket #25950) to add the LocalStorageConnector, but this was done only for the FE templates. Recently an issue has surfaced that the request sap/bc/lrep is being fired for freestyle application although the customer is not using any UI5 Flexibility feature. It turned out that flexibility is automatically enabled during UI5 bootstrap with the LrepConnector as soon as the app is connected to an OData service, and this was triggering the sap/bc/lrep request.

In order to avoid such issues in future the flpSandbox.html file of the freestyle apps should include flexibilityServices='[{"connector": "LocalStorageConnector"}]'.

Architecture Elaboration

Does it requires architecture elaboration?

Notes

Tasks

mikicvi-SAP commented 3 months ago

Changes validated via unit tests & internally. Closing as completed.