Closed IainSAP closed 3 months ago
Imports only requiring the AuthenticationType from @sap-ux/store are also importing its dependencies (e.g keytar) since this is an enum. We should replace with a real type (string literal) and move to dev dependencies (@sap-ux/ui5-config)
AuthenticationType
@sap-ux/store
https://github.com/SAP/open-ux-tools/blob/main/packages/ui5-config/src/types/middlewares.ts#L1
Prevents issues with bundling when keytar is included.
Does it requires architecture elaboration?
Done
IainSAP
commented
3 months ago
Description (include screenshots)
Imports only requiring the
AuthenticationTypefrom@sap-ux/storeare also importing its dependencies (e.g keytar) since this is an enum. We should replace with a real type (string literal) and move to dev dependencies (@sap-ux/ui5-config)https://github.com/SAP/open-ux-tools/blob/main/packages/ui5-config/src/types/middlewares.ts#L1
Value
Prevents issues with bundling when keytar is included.
Architecture Elaboration
Does it requires architecture elaboration?
Notes
Tasks