docirl
commented
3 months ago Please include the following change to deploy config prompting for abap for package/transport prompts:
Context
- the existing logic for 'validating' the transport request prompt (manual transport input) checked if the package provided started with $ L l T t and if so assumed the package was 'local' therefore not requiring a transport to be provided. The validation would return true for transport request manual input prompt. This is not correct, and as in the ui service generator, the package should be checked in the backend system
- the transport request ADT api (for 'select existing transport from list') when called with a package that is 'local' will return a warning text to state the package is local and no transport request is required, instead of returning a list of transports. We can use this response to show/hide the transport prompts. I asked ADT colleagues if other api's or methods were available to check the local status, but this is the same basic method they use also.
Summary of changes
- dont use static check of package name to validate transport request prompt
- check if package provided is 'local' from the backend. Use transport check adt api as used already when retrieving the list of transport requests
- if package is local, hide transport request prompts
If anything above is unclear let me know.
cianmSAP
As a developer, I want to prompt a user for abap deploy configuration, so that I updated and create the files as required for ABAP deployment
Description
The new inquirer module will provide the user with the prompts to gather the data for creating ABAP deployment configuration.
Technical Design
@sap-ux/abap-deploy-config-inquirerConsumed as part of a yeoman generatorAcceptance Criteria
Given I have a yeoman generator (or similar inquirer module) when I execute getPrompts then it will return the prompt
Notes
@sap-ux/createneeds to be enhanced also to incorporate the new functionalityTasks