SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
83 stars 41 forks source link

BUG - README.md template not located when bundling @sap-ux/fiori-generator-shared with generator #2594

Closed cianmSAP closed 1 day ago

cianmSAP commented 1 day ago

Related

https://github.com/SAP/open-ux-tools/issues/2554

Description

Due to the webpack pattern when bundling the fiori generator, it is expected the templates dir is one level above the calling function

Steps to Reproduce

Steps to reproduce the behavior:

  1. Bundle Fiori generator with latest @sap-ux/fiori-generator-shared
  2. See error Screenshot 2024-11-19 at 12 32 44

Expected results

No error

Actual results

Error thrown

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here OS:

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

cianmSAP commented 1 day ago

Fix is merged