SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
83 stars 41 forks source link

FEATURE - UI5 CDN URL to be `https://ui5.sap.com` by default #381

Closed petermuessig closed 2 years ago

petermuessig commented 2 years ago

As a UI5 architect 😁 , I want to ensure that all SAP Fiori elements and SAPUI5 freestyle applications are referring to https://ui5.sap.com as CDN URL, so that I can be independent from an SAP platform specific hosting solution like hana.ondemand.com.

Description

We - UI5 - clarified with all major platforms to allow the domain https://ui5.sap.com to be a safe host in the CSP settings (script-src). Only in some special cases in which developers define an inline CSP META tag it may be possible that the CSP settings prevent consuming UI5 from https://ui5.sap.com. In those cases, the developers must adopt their application (index.html).

Please also check for the existence of METAtags:

<meta http-equiv="Content-Security-Policy" content="script-src https://sapui5.hana.ondemand.com 'self' ...">

Or similar - and also adopt the URL in such META tags.

Technical Design

For all templates in Open UX Tools, please switch the UI5 CDN URL from https://sapui5.hana.ondemand.com to https://ui5.sap.com. For OpenUI5 we also consider a change - but I will inform you separately about this.

Acceptance Criteria

Given I will create a new SAP Fiori elements or SAPUI5 application when I use the Open UX Tools then I expect that the CDN URL for SAPUI5 points to https://ui5.sap.com.

Notes

Tasks

tobiasqueck commented 2 years ago

@petermuessig no productive code contains the old url anymore. It is only used in a test case where the caller provides a custom url which I wouldn't consider a problem.