SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
83 stars 35 forks source link

BUG - [backend-proxy-middleware] Error retrieving from secure store. #918

Open marianfoo opened 1 year ago

marianfoo commented 1 year ago

Related Bug

maybe Bug #742

Description

For me this is not an error that breaks anything, but only appears in the log. This may be different for others.

I run wdi5 Tests in GitHub Actions workflows. Since I updated UI5 Tools from 2.14.17 to 3.0.1, a error/warning appears about secure store, but the app it self still works. This only happens in Github Actions or in a Linux environment.
First example is this job under start app ordersv4fe ui5 108:
https://github.com/marianfoo/ui5-cc-excelUpload/actions/runs/4202734452/jobs/7291263259.

image

Next example is under the local environment with macOS M1 with Ubuntu Dev Container: image

Steps to Reproduce

Steps to reproduce the behavior: Run a UI5 App with fiori run and a fiori-tools-proxy. Project and yaml used for this examples above is this (generated by SAP App Generator):
https://github.com/marianfoo/ui5-cc-excelUpload/blob/main/examples/packages/ordersv4fe/ui5.yaml

Expected results

No Error/Warning in Console

Actual results

Warning/Error in console

Version/Components/Environment

Add any other context about the problem here OS: Linux

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

tobiasqueck commented 1 year ago

These look actually like two different things.

@zdravko-georgiev could you please have a look at the first one? It what situation are we logging an error? At maximum, I would expect a warning.

@ullasholla the 2nd one is something to discuss. Should we reduce this to a single warning that the secure storage is not available and log the rest only when debugging?

marianfoo commented 1 year ago

Forgot to add, i fixed the first error with https://github.com/marianfoo/ui5-cc-excelUpload/blob/2ea3c4d839a4c7afd0ce04667778a7fd4a88d458/.github/workflows/wdi5-test.yml#L31

Don't know if it helps you as I don't understand the underlying issue. I think I can undo this in the workflow anyway because it doesn't break anything.

zdravko-georgiev commented 1 year ago

@tobiasqueck We are trying to access the secure store in https://github.com/SAP/open-ux-tools/blob/main/packages/backend-proxy-middleware/src/base/proxy.ts#L320. And if there is an error only a warning is displayed. The error is displayed in debug mode. BUT in this case the error message comes directly from the secure store https://github.com/SAP/open-ux-tools/blob/main/packages/store/src/secure-store/keytar-store.ts#L36

tobiasqueck commented 1 year ago

@marianfoo is this error still occurring to you?

marianfoo commented 1 year ago

no, error is not there anymore

marianfoo commented 1 year ago

Sorry, have to reopen because looked at Github Actions where i used the workaround.
With this workaround the error is gone

Forgot to add, i fixed the first error with https://github.com/marianfoo/ui5-cc-excelUpload/blob/2ea3c4d839a4c7afd0ce04667778a7fd4a88d458/.github/workflows/wdi5-test.yml#L31

Currently using a ubuntu docker container and the error is coming up again.
Still no effect on the app, working fine.

image

with this:

  "devDependencies": {
    "@sap-ux/ui5-middleware-fe-mockserver": "^2.1.117",
    "@sap/ux-specification": "^1.108.12",
    "@sap/ux-ui5-tooling": "1.10.5",
    "@ui5/cli": "3.5.0"
  },

you need anymore infos?