SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
82 stars 33 forks source link

TBI - refactor `locate-reuse-lib.js` template #969

Open devinea opened 1 year ago

devinea commented 1 year ago

Description (include screenshots)

What will this TBI achieve, and how will it be measured as done. Is it documentation, increase of test coverage, refactoring

Refactor locate-reuse-lib.js template

Value

Optional - details on how this technical backlog item provides value to end-users or dev team eg. Performance, Quality, Maintainability. This will help determine the ranking in relation to feature development

Architecture Elaboration

Does it requires architecture elaboration?

Notes

Tasks

heimwege commented 6 days ago

hey guys 👋🏻

just stumbled across this issue. ui5linter currently complains about the following 26 findings of the current version of locate-reuse-lib.js in main:

<path>\locate-reuse-libs.js
   45:4  error Access of global variable '$' ($.ajax)
  113:23 error Import of deprecated module 'sap/base/util/UriParameters'
  121:13 error Access of global variable '$' ($.ajax)
  162:1  error Access of global variable 'sap' (sap.registerComponentDependencyPaths)
  171:3  error Access of global variable 'sap' (sap.ui.getCore)
  171:10 error Call to deprecated function 'getCore' (sap.ui.getCore)
  171:20 error Call to deprecated function 'attachInit' of class 'Core'
  172:18 error Access of global variable 'sap' (sap.ui.getCore)
  172:25 error Call to deprecated function 'getCore' (sap.ui.getCore)
  172:35 error Call to deprecated function 'getConfiguration' of class 'Core'
  172:54 error Call to deprecated function 'getLanguage' of class 'Configuration'
  184:5  error Access of global variable 'sap' (sap.ui.getCore)
  184:12 error Call to deprecated function 'getCore' (sap.ui.getCore)
  184:22 error Call to deprecated function 'attachInit' of class 'Core'
  190:7  error Access of global variable 'sap' (sap.ushell.Container.createRenderer)
  198:5  error Access of global variable 'sap' (sap.ui.getCore)
  198:12 error Call to deprecated function 'getCore' (sap.ui.getCore)
  198:22 error Call to deprecated function 'attachInit' of class 'Core'
  200:20 error Access of global variable 'sap' (sap.ui.getCore)
  200:27 error Call to deprecated function 'getCore' (sap.ui.getCore)
  200:37 error Call to deprecated function 'getConfiguration' of class 'Core'
  200:56 error Call to deprecated function 'getLanguage' of class 'Configuration'
  211:4  error Access of global variable 'sap' (sap.ui.getCore)
  211:11 error Call to deprecated function 'getCore' (sap.ui.getCore)
  211:21 error Call to deprecated function 'attachInit' of class 'Core'
  214:5  error Access of global variable 'sap' (sap.ushell.Container.createRenderer)

Is fixing those part of this issue as well or should I open a separate one?