search

SAP / openui5-fhir

The openui5-fhir project connects the worlds of UI5 and FHIR®. Build beautiful and enterprise-ready web applications based on the FHIR® specification.
https://sap.github.io/openui5-fhir
Apache License 2.0
33 stars 6 forks source link

fix: support combined filters #265

Closed AmirthavalliG closed 3 years ago

AmirthavalliG commented 3 years ago

initialise the combined filters property by using the ui5 FilterProcessor.combineFilter to get the combined filter. this will merge filters with bAnd property to be true. Similar to oData implementation https://github.com/SAP/openui5/blob/master/src/sap.ui.core/src/sap/ui/model/odata/ODataListBinding.js#L856 This property is necessary for mdc based filters to work as expected https://github.com/SAP/openui5/blob/master/src/sap.ui.mdc/src/sap/ui/mdc/field/FieldValueHelpTableWrapperBase.js#L517 List Binding getFilterInfo Default Implemantation https://github.com/SAP/openui5/blob/master/src/sap.ui.core/src/sap/ui/model/ListBinding.js#L428

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.01%) to 95.875% when pulling b2292fa97f60661f9cedd497e2c3b7e70a7dbdc6 on fix/combined-filters into 3aa42ba264bdadef527417e4d5a84483bdcc313e on master.

openui5fhirbot commented 3 years ago

:tada: This PR is included in version 2.2.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: