search

SAP / openui5-fhir

The openui5-fhir project connects the worlds of UI5 and FHIR®. Build beautiful and enterprise-ready web applications based on the FHIR® specification.
https://sap.github.io/openui5-fhir
Apache License 2.0
33 stars 6 forks source link

fix: complex filter query #267

Closed AmirthavalliG closed 3 years ago

AmirthavalliG commented 3 years ago

In case of mdc controls the filter object is generated by ui5 and hence the valuetype for string is not available to determine if it needs to be enclosed in quotes. The purpose of this PR is

  1. to identify string type based on js types and enclose it in quotes. if a valid date is given in string it wont be enclosed.
  2. to remove the conversion to iso string as if the type of the resource is not date time this would lead to incorrect filter results. For.eg. birthDate is of type date. This is a short term solution to handle dates and timezones(application will have the responsiblity to send it appropriately). Both of these are shorterm solutions The long term solution is to determine the type of a search parameter based on the metadata The long term solution of having Fhir date types and handling it at the model layer will be done in a later stage
openui5fhirbot commented 3 years ago

:tada: This PR is included in version 2.2.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: