search

SAP / openui5-fhir

The openui5-fhir project connects the worlds of UI5 and FHIR®. Build beautiful and enterprise-ready web applications based on the FHIR® specification.
https://sap.github.io/openui5-fhir
Apache License 2.0
33 stars 6 forks source link

fix(sap.fhir.model.r4.FHIRListBinding): Trigger binding updates when resource is removed or a rollback is performed #331

Closed AmirthavalliG closed 2 years ago

AmirthavalliG commented 2 years ago

This PR is for fixing the list binding still showing the removed items if submit changes is not done immediately. Use another array to capture the client removed resources and fill it appropriately to decide whether during reset changes the contexts needs to be recreated (for those resources which are not yet submitted but was removed using the remove operation)

flovogt commented 2 years ago

And please write a test also for the TreeBinding and see if it works as expected

AmirthavalliG commented 2 years ago

And please write a test also for the TreeBinding and see if it works as expected

@flovogt : As discussed we will not consider the TreeBinding as part of this PR as it has very limited scope when compared to the list binding. We would revisit the TreeBinding later

flovogt commented 2 years ago

And please write a test also for the TreeBinding and see if it works as expected

Clarified not in the scope of this PR.

openui5fhirbot commented 2 years ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: