sap.m.FacetFilter doesn't show correct i18n texts after language change

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.

http://openui5.org

Apache License 2.0

2.95k stars 1.23k forks source link

sap.m.FacetFilter doesn't show correct i18n texts after language change #1258

Closed nzamani closed 7 years ago

nzamani commented 7 years ago

OpenUI5 version: 1.42.8 (maybe older version as well)

Browser/version (+device/version): all

URL: https://sapui5.hana.ondemand.com/explored.html#/sample/sap.m.sample.FacetFilterLight/preview

Steps to reproduce the problem:

go to the link above
open dev console
enter sap.ui.getCore().getConfiguration().setLanguage("de"); into the console (choose "en" if your browser already uses "de")

What is the expected result? The text in the summaryBar (filterBar) should be displayed in the language you chose above

What happens instead? Nothing. The language stays as it is.

Any other information? I already analyzed this at stackoverflow and I offered also some minimal code that should fix the issue.

ShtiliyanUzunov commented 7 years ago

Hi nzamani,

I was able to reproduce the issue. Internal ref: 1680336898

BR, Shtiliyan

gerym commented 7 years ago

Hi nzamani,

This is not an issue. Please read the following info from the core/Configuration.js file:

When the language has changed, the Core will fire its
{@link sap.ui.core.Core#event:localizationChanged localizationChanged} event.

The framework does not guarantee that already created, language

dependent objects will be updated by this call. It therefore remains best practice
for applications to switch the language early, e.g. before any language dependent
objects are created. Applications that need to support more dynamic changes of
the language should listen to the localizationChanged event and adapt
all language dependent objects that they use (e.g. by rebuilding their UI).

Kind Regards, Gery

boghyon commented 7 years ago

Could we re-open this issue as "enhancement"? Even if it's documented, it is a weird behavior that some controls change their locale automatically and some have to be rebuilt for that. It would be nice if we could just hot-swap the language/locale completely at anytime without listening to localizationChanged.

nzamani commented 7 years ago

NoelHendrikx commented 7 years ago

aka-darth commented 7 years ago

spixi commented 6 years ago

estevan086 commented 5 years ago

BloggingWithJan commented 1 year ago

dfenerski commented 1 year ago

codeworrior commented 1 year ago

As mentioned here, our management decided NOT to invest into this topic.