search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.96k stars 1.24k forks source link

max-width of sap.m.MenuButton #1310

Closed boghyon closed 7 years ago

boghyon commented 7 years ago

OpenUI5 version: All since MenuButton exists

Tested browsers (OK/FAIL) on Windows 10: FAIL: FF, IE, Edge, Chrome, Opera OK: -

URL (minimal example if possible): https://embed.plnkr.co/zXYqbL/

Steps to reproduce the problem:

  1. Visit the provided example page

What is the expected result? Width of the MenuButton is applied (or auto if no width is given): expected

What happens instead? MenuButton has max-width: 12rem. max-width of MenuButton

Any other information? Not sure if it's a bug or just not documented.

hristop commented 7 years ago

Hi @boghyon,

Thank you for mentioning this issue. This is the expected behavior of the sap.m.MenuButton, however, this indeed is not documented anywhere thus we have created internal incident: 1780055997.

Best Regards,

Hristo

hristop commented 7 years ago

Hi @boghyon,

The documentation was updated and this will be available in the of the library.

Best Regards,

Hristo

boghyon commented 2 years ago

Documentation fixed with https://github.com/SAP/openui5/commit/baabc9d1f061835bfd67199731a5cf9ff3756b63

boghyon commented 9 months ago

Documentation fixed with https://github.com/SAP/openui5/commit/baabc9d1f061835bfd67199731a5cf9ff3756b63

... now reverted in this new change https://github.com/SAP/openui5/commit/88b563d35a84cf3cbd13b8114fabec7a53f7281f together with the removal of max-width: 12rem;. Now the sap.m.MenuButton can expand up to 100% width.