SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.96k stars 1.24k forks source link

SmartFilterBar cannot disable basic search #2149

Closed alex-ecenta closed 6 years ago

alex-ecenta commented 6 years ago

Version: "1.54.7"
We'd like to get rid of the basic search field that is presented with the SmartFilterBar
enableBasicSearch="false" has no effect.

JumpNRun commented 6 years ago

Hi @alex-ecenta ,

Settings enableBasicSearch to "false" should render the SmartFilterBar without basic search field. But the property must be set in the View, before initialization of the SmartFilterBar. Changing the property after initialization does not have an effect. From the documentation: "Most of the attributes/properties are not dynamic and cannot be changed once the control has been initialized."

Please let us know if this solved the issue. If it didn't, please provide us an example where this issue can be reproduced.

Best regards, Alex

alex-ecenta commented 6 years ago

@JumpNRun

Can you please clarify, where should we explicitly set the property before the control is rendered? We have the following code:

var oSmartFilterbar = this.getView().byId("smartFilterBar");
oSmartFilterbar.setEnableBasicSearch(false);

In both onInit and onBeforeRebinding.

Is that not the right approach, or not the right place?

JumpNRun commented 6 years ago

Hi @alex-ecenta

Not before the control is rendered, but before it's initialized. It must be set in the view. The default value for the enableBasicSearchproperty is false. So it is set to true in the view of your app. Maybe you are also using a smart template?

This is SAPUI5 technology, not OpenUI5. Please understand that we do not provide consultation for SAPUI5 specific topis on this platform, hence i close this issue. If you still think that there is a problem in the framework, at least give us a running example in which the problem can be reproduced.

Thanks and best regards, Alex