search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.96k stars 1.24k forks source link

Timepicker resets value when using 24:00 #3037

Closed pedromagueija closed 3 years ago

pedromagueija commented 4 years ago

OpenUI5 version: latest (seems to be for all though)

Browser/version (+device/version): Edge/85.0.564.68

Any other tested browsers/devices(OK/FAIL):FAIL

URL (minimal example if possible): https://openui5.hana.ondemand.com/entity/sap.m.TimePicker/sample/sap.m.sample.TimePicker

User/password (if required and possible - do not post any confidential information here): n/a

Steps to reproduce the problem:

  1. On the bottom control of the demo page using the keyboard to type in 24:00:00
  2. Now change the value by typing in 02:00:00 (should change fine)
  3. Type in again 24:00:00
  4. Click the picker button (should display 24:00:00)
  5. Try using the keyboard to type in again the value to 02:00:00

What is the expected result? The value should have changed to 02:00:00

What happens instead? The control resets the value to 24:00:00

Any other information? (attach screenshot if possible) When using databinding the 24:00:00 value is not accepted by the control even when using support2400="true". It always uses 00:00:00.

dimovpetar commented 4 years ago

Hello @pedromagueija ,

Thank you for sharing this finding. I've created an internal incident 2070389230. The status of the issue will be updated here in GitHub.

Regards, Petar

NHristov-sap commented 3 years ago

Hi @pedromagueija ,

This issue is already fixed and the fix is included in version 1.83.

Best Regards, Nikolay Hristov UI5 Developer

KCezar commented 1 year ago

@pedromagueija @dimovpetar @NHristov-sap

Hello guys,

There is no 24 in the time conventions in primitive types. In the documentation it is clear the primitive types to be worked in sapui5. This was not a bug and is causing rework for many customers around the world who follow the conventions. I suggest changing the 24 to 00 in the UI, which is the most common in all UI tools. Or return to the convention as it was before.

https://sapui5.hana.ondemand.com/#/topic/e1ddc69c01474faf830a522db8c9238a

https://sapui5.hana.ondemand.com/#/topic/07e4b920f5734fd78fdaa236f26236d8.html

https://sapui5.hana.ondemand.com/#/topic/07e4b920f5734fd78fdaa236f26236d8.html

https://www.odata.org/documentation/odata-version-2-0/overview/

https://www.w3.org/TR/xmlschema11-2/#time