search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.95k stars 1.23k forks source link

sap/m/DateTimePicker: JSDoc definition for public member functions incomplete #3709

Closed BenReim closed 1 year ago

BenReim commented 1 year ago

OpenUI5 version: 1.111.0

Steps to reproduce the problem:

    const myDateTimePicker = /**@type {import('sap/m/DateTimePicker').default} */ (this.byId("dateTimePicker"));

    // Property 'setMaxDate' does not exist on type 'DateTimePicker'. Did you mean 'getMaxDate' ?ts(2551)
    myDateTimePicker.setMaxDate(new Date());
codeworrior commented 1 year ago

As commented in SAP/ui5-typescript/issues/389, this is caused by the JSDoc comments for setMaxDate (and maybe others) in the sap/m/DatePicker.js. Those JSDoc comments are not marked with @public which in UI5 is equivalent to marking them as @private.

JSDoc needs to be adapted at least for

plamenivanov91 commented 1 year ago

Hello @BenReim ,

I created internal incident 2370007787

We will notify you in this issue when it's fixed.

Regards, Plamen Ivanov

didip1000 commented 1 year ago

Hey @BenReim,

A fix has been submitted to the master branch, and will be available in release 1.113.

Best, Diana P.

boghyon commented 1 year ago

Fixed in https://github.com/SAP/openui5/commit/1b28ca25ccd1f52c39684b82e39bb71790e07259