search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.95k stars 1.23k forks source link

sap.m.FeedInput button and icon alignment #3745

Closed maximkadrov closed 1 year ago

maximkadrov commented 1 year ago

OpenUI5 version: 1.113.0

Browser/version (+device/version): Chrome 112.0.5615.137/Mac OS

Any other tested browsers/devices(OK/FAIL): any

URL (minimal example if possible): SAPUI5 Demo

User/password (if required and possible - do not post any confidential information here): -

Steps to reproduce the problem:

  1. Button is not aligned properly
image

It seems that the button and icon inside the button are not aligned with the input field in the sap.m.FeedInput control

didip1000 commented 1 year ago

Hello @maximkadrov,

Thank you for sharing this finding. I've created an internal incident 2370053041. The status of the issue will be updated here in GitHub.

Regards,

Diana

megsen commented 1 year ago

Hello colleagues,

As per the Demokit sample, the button and the icon within the button are aligned properly and not moving out of the zone. I have attached two images, for both the Horizon and Quartz themes.

Demokit link

If the issue still persists in your application, you can send over a link so that I can look into it.

Thanks and Regards, Meghna

Horizon theme image

Quartz theme image

maximkadrov commented 1 year ago

Hello @megsen,

I checked this demo page on Chrome 112.0.5615.137/Mac OS and Safari 15.3, the problem still persists only in 1.113.0 version

Demo

image
megsen commented 1 year ago

Hello all,

We have made the changes for the button and icon in compact mode as well, and now it is properly aligned. The change will be available from the next version of UI5.

Thanks and Regards, Meghna

flovogt commented 1 year ago

Fixed with https://github.com/SAP/openui5/commit/2db42928de7cf1dc022696dc7b49af52d818d12a