dobrinyonkov
commented
1 year ago Hello @pubmikeb ,
Thank you for sharing this finding. I've created an internal incident 2380126372. The status of the issue will be updated here in GitHub.
Regards, Dobrin
flovogt
I've noted that ui5.yaml of some libs has single quotes, e.g.:
while another — double:
Unfortunately, https://github.com/SAP/openui5/commit/26a38678e1f024714fe998238622111ec2a22f81 (#3537) fixed this issue just for a single file:
src/sap.ui.mdc/ui5.yaml. In fact, there are many other files with the same inconsistency. In sake of consistency, it would be better to apply single code style to the entire UI5 codebase and ensure it with the linters.Below a list of all
ui5.yaml's with a single quote mark forspecVersion:sap.m\test\sap\m\demokit\tutorial\walkthrough\26\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\27\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\28\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\29\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\30\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\31\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\32\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\33\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\34\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\35\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\36\ui5.yamlsap.m\test\sap\m\demokit\tutorial\walkthrough\37\ui5.yamlsap.m\test\sap\m\demokit\tutorial\worklist\01\ui5.yamlsap.m\test\sap\m\demokit\tutorial\worklist\02\ui5.yamlsap.m\test\sap\m\demokit\tutorial\worklist\03\ui5.yamlsap.m\test\sap\m\demokit\tutorial\worklist\04\ui5.yamlsap.m\test\sap\m\demokit\tutorial\worklist\05\ui5.yamlsap.m\test\sap\m\demokit\tutorial\worklist\06\ui5.yamlsap.m\test\sap\m\demokit\tutorial\worklist\07\ui5.yamlsap.m\test\sap\m\demokit\worklist\ui5.yamlsap.tnt\test\sap\tnt\demokit\toolpageapp\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\01\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\02\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\03\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\04\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\05\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\06\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\07\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\08\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\09\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\10\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\11\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\12\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\13\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\14\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\databinding\15\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\mockserver\01\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\mockserver\02\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\mockserver\03\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\mockserver\04\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\01\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\02\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\03\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\04\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\05\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\06\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\07\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\08\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\09\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\10\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\11\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\12\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\13\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\14\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\15\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\16\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\navigation\17\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\01\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\02\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\03\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\04\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\05\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\06\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\07\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\08\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\09\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\10\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\odatav4\11\ui5.yamlsap.ui.core\test\sap\ui\core\demokit\tutorial\troubleshooting\01\ui5.yamlsap.ui.integration\test\sap\ui\integration\performance\ui5.yaml