search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.96k stars 1.24k forks source link

UploadSet noData IllustratedMessage with illustrationSize="Dot" console error #3933

Closed loatherer closed 9 months ago

loatherer commented 10 months ago

OpenUI5 version: 1.108.14

Browser/version (+device/version): Google Chrome/ Version 120.0.6099.110

Any other tested browsers/devices(OK/FAIL): Microsoft Edge Version 120.0.2210.77 / FAIL

URL : https://sapui5.hana.ondemand.com/sdk/#/entity/sap.m.IllustratedMessage/sample/sap.m.sample.IllustratedMessageInPage

Steps to reproduce the problem:

  1. Select illustration size "Dot".
  2. Select illustration type "NoData".
  3. Check the console.

image

Even though the svg loads, the error comes to console

image

It says it can't find the svg file. I get same error in Upload Set as it gets noData IllustratedMessage from the same directoy:

"lib/ui5/resources/sap/m/themes/base/illustrations/sapIllus-Dot-NoData.svg"

dobrinyonkov commented 9 months ago

Hello @loatherer ,

Thank you for sharing this finding. I've created an internal incident DINC0037351. The status of the issue will be updated here in GitHub.

Regards, Dobrin

plamenivanov91 commented 9 months ago

Hello @loatherer ,

This is expected behavior.

In the IllustratedMessage we have a certain logic where if an illustration is missing, we apply the "bigger" one.

In this case, the "Dot" size is missing (simply because it looks the same as the "Spot" size), therefore we for the "Dot" size we fallback to the "Spot" size and use it. There is even a warning which states it in your screenshot.

Since the SVG is vector, we don't have to package "Dot" size, we can just the "Spot" size, in the end we end up with the desired SVG for the "Dot" size while maintaining smaller project and less traffic.

Regards, Plamen Ivanov