SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.96k stars 1.24k forks source link

Personalisation (P13N) does not work as expected #3940

Closed jankrieg closed 9 months ago

jankrieg commented 10 months ago

This is with respect to issue: https://github.com/SAP/openui5/issues/3902?ssp=1&darkschemeovr=1&setlang=de-DE&safesearch=moderate

We added two columns, see zip file. sap.m.sample.p13n.Engine.zip

OpenUI5 version: 1.120.4

Browser/version (+device/version):

Any other tested browsers/devices(OK/FAIL):

URL (minimal example if possible): We added two more columns to this example (see attached zip file): https://openui5.hana.ondemand.com/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine/codel

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Click on "settings" and display all fields AllColumnsVisible

  2. Click on settings again an move the "Last name" to the first position and "City1" to last position. FirstChange

  3. Everything is fine. The columns are displayed in the order shown in settings.

  4. Now change the order of columns again: Move City to the first position and First Name to the 5th position.

SecondChange

Now the order of the columns are not in sync with the settings TableAndSettingsAfterSecondChange

What is the expected result? The order of columns displayed should be identical to the order of columns shown in the settings

What happens instead?

Any other information? (attach screenshot if possible)

i556484 commented 9 months ago

Hello @jankrieg, Thank you for sharing this finding. I've created an internal incident DINC0033396. The status of the issue will be updated here in GitHub.

martinhaeuser commented 9 months ago

Hello @jankrieg, thanks for sharing this finding. Judging by the sample, an older patch of release 1.120 has been used (1.120.0), here I am able to reproduce the issue mentioned. This is a known issue which has been fixed with the recent change 82800ef - I've just checked with the current patch (1.120.4) and the issue is no longer reproducible. Could you please double check the used version? With the latest patch the issue is not reproducible, otherwise kindly revert.

jankrieg commented 9 months ago

Hi guys,

sorry, but it is not 100% okay. We executed the same with 1.120.4 and now there is another issue:

After a few changes (see above) the order of columns looks like this: AfterAFewChanges

Then we did two changes before pressing OK: Move "Last Name" to the first postion and "Size1" to the end: lastChange

The result was that: result

The system only executed the first change ("Last Name" to first postion) but not the second change.

Regards, Jan

flovogt commented 9 months ago

@jankrieg thanks for posting this information. Could you please create a new github issue and provide further details there?

boghyon commented 9 months ago

The issue is actually still reproducible in https://sdk.openui5.org/nightly/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine/code

Based on the initial issue description:

  1. Click on "settings" and display all fields.
  2. Click on settings again an move the "Last name" to the first position and "City" to last position (Everything is fine. The columns are displayed in the order shown in settings).
  3. Now change the order of columns again: Move "City" to the first position and "First Name" to the last position.

The positions are not in sync.

jankrieg commented 9 months ago

Hi guys, just saw that you reopen this one. I create another ticket with a few more details. Hope that helps.

martinhaeuser commented 9 months ago

Hi @jankrieg , thanks alot for your efforts and the detailed description. I am currently investigating the issue, I will get back to you soon.

Since you opened a new issue, I will close this issue to avoid duplicate maintenance of the issue.

boghyon commented 9 months ago

For future readers: please continue with https://github.com/SAP/openui5/issues/3948