search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.94k stars 1.23k forks source link

Personalisation Engine change sort sequence does not fire stateChange #3945

Closed swayongshen closed 7 months ago

swayongshen commented 8 months ago

OpenUI5 version: 1.120.4

Browser/version (+device/version):

Any other tested browsers/devices(OK/FAIL):

URL (minimal example if possible): Replicable on samples https://sapui5.hana.ondemand.com/1.120.4/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine/code

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Add console.log('hi') to the handleStateChange function.
  2. Select any 2 columns to sort using the personalisation gear icon button.
  3. Press 'OK'
  4. 'hi' is printed in the console twice.
  5. List is sorted by the columns specified in step 2
  6. Reorder the sort sequence of the 2 sorted columns from step 2
  7. Press 'OK'
  8. 'hi' is not printed in the console.
  9. List did not sort according to the new sort sequence from step 5, and upon opening the personalisation sort window, the sort sequence did not update and is still same as in step 2.

What is the expected result? Personalisation engine should fire the function provided to attachStateChanged when the sort sequence is reordered from an existing sort sequence

What happens instead? Personalisation engine does not fire the function provided to attachStateChanged when the sort sequence is reordered from an existing sort sequence

Any other information? (attach screenshot if possible)

image
flovogt commented 8 months ago

Thanks a lot for creating this issue. I have created an internal incident DINC0036142. The responsible team will post further updates here.

swayongshen commented 7 months ago

Thanks a lot for creating this issue. I have created an internal incident DINC0036142. The responsible team will post further updates here.

@flovogt I'm an SAP employee, am I able to track this issue with an internal tool/site?

flovogt commented 7 months ago

@swayongshen its just for SAP internal tracking, important updates will be made here in github

martinhaeuser commented 7 months ago

Hi @swayongshen,

thank you for opening this issue. Please note that the issue has been fixed.

Please retest with patch 1.120.5: https://sapui5.hana.ondemand.com/1.120.5/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine/code

The issue is no longer reproducible. Kindly reach out in case of any further questions or concerns.