search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.94k stars 1.23k forks source link

Correct padding for ObjectPageLayout showing title in header content on display class Desktop-XL #3960

Open patrickhuy opened 7 months ago

patrickhuy commented 7 months ago

When ObjectPageLayout is set to showTitleInHeaderContent and the header is displayed with on a screen of class Desktop-XL the content area (and especially noticeable: the image) don't have a top padding.

This can be observed here: https://jsfiddle.net/395hrpye/ (the padding from the icon to top goes away when entering the Desktop-XL layout)

https://github.com/SAP/openui5/assets/66731536/1f0dd13d-586b-4223-bcfa-3f4011c96f9a

This PR applies the padding from Tablet and Desktop also for Desktop-XL in both the theme "horizon" as well as "quartz".

flovogt commented 7 months ago

Hi @patrickhuy, Thank you for sharing your enhancement proposal. I've created an internal incident DINC0053713. The responsible team will have handle this PR and post further updates here.

codeworrior commented 7 months ago

Hi @flovogt, there's already DINC0053067 for the same issue. Shall we close DINC0053713 as a duplicate?

flovogt commented 7 months ago

Duplicate DINC0053713 is closed. Thanks for pointing this out @codeworrior