search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.94k stars 1.23k forks source link

Improve JSDocs / TS Types for Events of sap.m.VariantManagement #3967

Closed BenReim closed 6 months ago

BenReim commented 7 months ago

OpenUI5 version: 1.120.4

Issue Many of the types for event parameters of the sap.m.VariantManagement control are unnecessarily broad. With type narrowing, developers could benefit from increased type safety, better auto completion etc.

For example, the manage has a event parameter renamed typed as object[]. The more specific types are only available as free text in the description:

List of changed variants. Each entry contains a key (the variant key) and a name (the new title of the variant).

yanaminkova commented 7 months ago

Hello @BenReim,

Thank you for sharing your enhancement proposal. I've created an internal incident DINC0063473. The status of the issue will be updated here in GitHub.

Regards, Yana

yanaminkova commented 6 months ago

Hello @BenReim ,

The enhancement is done: b32a0190a53f03c406b1bd3871482630e6115f1c

Kind regards, Yana