search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.94k stars 1.23k forks source link

sap.m.MultiInput - First suggestion item selected no matter which one is clicked #3970

Closed eliasshhh closed 7 months ago

eliasshhh commented 7 months ago

OpenUI5 version: 1.119.2 (upgraded from 1.108 which did not have this problem)

Browser/version (+device/version): Chrome Version 121.0.6167.85 (Official Build) (x86_64)

Any other tested browsers/devices(OK/FAIL): Safari (FAIL), Firefox (FAIL)

URL (minimal example if possible): https://sapui5.hana.ondemand.com/1.119.2/#/entity/sap.ui.comp.valuehelpdialog.ValueHelpDialog/sample/sap.ui.comp.sample.valuehelpdialog.recommended

User/password (if required and possible - do not post any confidential information here): n/a

Steps to reproduce the problem:

  1. Navigate to the URL above
  2. Clear tokens in first multi-input (Products (Advanced Search without suggestions))
  3. Type the letter P and click on PD-104 from the suggestion -> The token is now PD-101 instead
  4. Repeat step 3 and this time no token is added because it tries to pick PD-101 which is already a token

If instead of clicking directly on PD-104, we use the keyboard arrows to highlight it first, then it can be added as a token either by clicking on it or pressing enter.

What is the expected result? Clicking on a suggested item should add it to the token list if it isn't already selected.

What happens instead? Clicking on a suggested item does not consider the one we clicked but rather the one that is highlighted (first one by default but can be changed if we use the keyboard arrows)

Any other information? (attach screenshot if possible) The issue was not reproducible on 1.120.6. Is this something that will be backported to supported earlier releases such as 1.119?

yanaminkova commented 7 months ago

Hello @eliasshhh,

Thank you for sharing this finding. I've created an internal incident DINC0063496. The status of the issue will be updated here in GitHub.

Regards, Yana

elenastoyanovaa commented 7 months ago

Hello @eliasshhh ,

Version 1.119 is not a maintenance version https://ui5.sap.com/versionoverview.html so there could not be a downport.

Please use the maintenance versions listed in the link.

Kind Regards, Elena