PDFViewer does not show PDF content anymore

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.

http://openui5.org

Apache License 2.0

2.94k stars 1.23k forks source link

PDFViewer does not show PDF content anymore #3974

Closed pietromodi closed 6 months ago

pietromodi commented 6 months ago

OpenUI5 version: latest 1.84 (1.84.42) / latest 120 (on DemoKit)

Browser/version (+device/version): Tested on Chrome 121 (121.0.6167.161)

Any other tested browsers/devices(OK/FAIL): No other tests done

Steps to reproduce the problem:

Open a view with a PDFViewer linked to a valid PDF from a Desktop/Tablet browser

What is the expected result? The PDF content is shown in the viewer content area

What happens instead? No PDF content is shown

Any other information? (attach screenshot if possible) https://sapui5.hana.ondemand.com/sdk/#/entity/sap.m.PDFViewer/sample/sap.m.sample.PDFViewerEmbedded

Custom application with 1.84.31 (works OK, shows an invalid PDF message)

Custom application with 1.84 evergreen alias 1.84.42 (does not work, content area not shown)

edemuck4timbuktu commented 6 months ago

Hi, I face the same issue. Also happend with OpenUI5 Version 1.108.25. With the version 1.108.24 there is no problem. With the newest version of 1.114 there is also no problem.

edemuck4timbuktu commented 6 months ago

@pietromodi With the value true of the sap.m.PDFViewer property "isTrustedSource" the issue is fixed. Tested with SAPUI5 Version 1.108.28 (newest).

k-shalini commented 6 months ago

In case you do not see the PDF in embedded mode, you may use the Download button on the right to download the PDF and display it.

If you are using a custom built app, it needs to be adapted accordingly:

Set the property isTrustedSource to true in your app code. The PDF content is directly shown within the PDFViewer as before. (Recommended: Set this property to true only when the PDF is generated by the application or the PDF is scanned for viruses.)
If isTrustedSource is set to false, the PDFViewer opens with the displayType set to "Link" on desktop devices, which overrides any configuration that has been provided by the application for the property displayType. This means that the PDFViewer appears as a toolbar with a download button.

You must update the application and set property isTrustedSource = true in order to display the PDF’s. If you leave it as is (false), then you can use the Download button on the right to open the PDF.

Best regards, Shalini (PO - Suite controls)