search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.92k stars 1.23k forks source link

Add custom launchpad item deprecation #3990

Closed whydrae closed 4 months ago

whydrae commented 4 months ago

OpenUI5 version: since 1.120

Browser/version (+device/version): all

URL (minimal example if possible): https://ui5.sap.com/#/api/sap.ushell.renderers.fiori2.Renderer%23methods/addHeaderItem

Steps to reproduce the problem:

  1. Since 1.120, sap.ushell.renderers.fiori2.Renderer is deprecated, instead experimental sap.ushell.services.Extension shall be used.
  2. However, addHeaderItem function is not deprecated, but it looks like it should point to a new function createHeaderItem of the extension.

The question is: which of the functions shall be used in the production? One of them is deprecated, another one is experimental. As I remember, guidelines say that (ideally) neither should be used.

Shall documentation be adjusted and deprecate the addHeaderItem if favour of createHeaderItem?

IlianaB commented 4 months ago

Hello @whydrae , The sap.ushell.renderers.fiori2.Renderer is part of sap.ushell library, not of OPENUI5. GitHub is a place for managing issues for OPENUI5 only. Please, open a ticket in SAP ticket system for managing incidents.

Regards, Iliana

boghyon commented 2 months ago

https://ui5.sap.com/#/entity/sap.ushell.services.Extension/sample/sap.ushell.sample.HeaderItem/code might help. See also other FLP samples there. But yes, FLP is not part of this OpenUI5 repo.