SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.92k stars 1.23k forks source link

Select Dialog confirm event not fired with OData Model Change #3992

Closed caroline-ferri closed 4 months ago

caroline-ferri commented 4 months ago

OpenUI5 version:

Browser/version (+device/version): Browser: Chrome Version: tested on 1.120.0 and 1.122.0 with Snippex

Any other tested browsers/devices(OK/FAIL):

URL (minimal example if possible): https://snippix.only.sap/#739777

User/password (if required and possible - do not post any confidential information here): N/A

Steps to reproduce the problem:

  1. Open the dev console and set a breakpoint at the following lines for the SelectDialog component: https://github.com/SAP/openui5/blob/1872bb06a927572a3c1cdc5cb1b4c7e076161a49/src/sap.m/src/sap/m/SelectDialog.js#L1093 https://github.com/SAP/openui5/blob/1872bb06a927572a3c1cdc5cb1b4c7e076161a49/src/sap.m/src/sap/m/SelectDialog.js#L1109 https://github.com/SAP/openui5/blob/1872bb06a927572a3c1cdc5cb1b4c7e076161a49/src/sap.m/src/sap/m/SelectDialog.js#L1115
  2. Open the select dialog, select a few items and press the "Select" button
  3. confirm that the fireConfirmAndUpdateSelection() is called from the else section
  4. Open the select dialog, and search "Canyon"
  5. select a few options and press the "Select" button
  6. Notice that the breakpoint reached is in the if part of the if/else statement since this._sSearchFieldValue is not null
  7. Press play and observe that fireConfirmAndUpdateSelection() breakpoint within the if section is never reached when a search term is provided

What is the expected result? When pressing "Select" on the SelectDialog the confirm event should always be fired.

What happens instead? The confirm event is not fired when a search term is provided and the SelectDialog is bound to an OData model.

Any other information? (attach screenshot if possible)