search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.92k stars 1.23k forks source link

`status` parameter of `uploadComplete` event for `sap.ui.unified.FileUploader` should be of type `int` #4012

Closed dfenerski closed 3 months ago

dfenerski commented 3 months ago

OpenUI5 version: latest

The parameters of an event should be correctly typed & reflect the true state of the data at runtime. For the status param of uploadComplete in FileUploader this is not the case - it is typed as string but as per MDN docs it is a number.

Furthermore, the TS type definitions are generated from the JS source. So they are wrong too: image image

aborjinik commented 3 months ago

Thank you! Internal incident DINC0107005 is created for this github issue.

didip1000 commented 3 months ago

Hey @dfenerski,

The issue was fixed with your contribution, it will be available in UI5 release version 1.124.

Thank you, Diana

dfenerski commented 3 months ago

Thanks for the feedback