search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.92k stars 1.23k forks source link

sap.ui.layout.form.SimpleForm Aggregation Clone Issue #4015

Open edemuck4timbuktu opened 3 months ago

edemuck4timbuktu commented 3 months ago

OpenUI5 version: 1.120.11 Browser/version (+device/version): Chrome Version 122.0.6261.131 (Offizieller Build) (64-Bit) URL (minimal example if possible): https://plnkr.co/plunk/uyRhWUvienyHvQ1p

Steps to reproduce the problem:

  1. Start the plnkr Demo App

What is the expected result? The sap.m.OverflowToolbar of each sap.ui.layout.form.SimpleForm should be displayed. Only the last sap.ui.layout.form.SimpleForm displayed the toolbar.

What happens instead? The sap.m.OverflowToolbar of the sap.ui.layout.form.SimpleForm, which is the content of a sap.f. Card, isn't displayed.

Any other information? (attach screenshot if possible) First analysis: The cloning of the sap.ui.layout.form.SimpleForm triggers by rendering of the aggregation pages of the sap.m.Carousel isn't working properly. After cloning the SimpleForm, the aggregation toolbar isn't part of the new SimpleForm. See https://github.com/SAP/openui5/blob/1.120.11/src/sap.ui.layout/src/sap/ui/layout/form/SimpleForm.js#L1141

aborjinik commented 3 months ago

Thanks for reporting this issue. In UI5 hidden aggregations are not part of clones. The SimpleForm uses the form as a hidden aggregation and this seems like the main issue here. Internal incident DINC0107232 is created for this github issue.

UserAbcd1234 commented 1 month ago

Hi,

this issue is already solved with SAPUI5 version 1.121

flovogt commented 1 month ago

Fixed with https://github.com/SAP/openui5/commit/a8a81993b1782b8d47dbafa355f262f7b818ac35

edemuck4timbuktu commented 3 weeks ago

@flovogt Thank you ;) Why is this fix not in the long-term maintenance version 1.120 ? image

GerganaKremenska commented 1 week ago

Hello @edemuck4timbuktu, Thank you for sharing this finding. I've created an internal incident DINC0203677 reagrding your downport request. The status of the issue will be updated here in GitHub. Regards, Gergana

UserAbcd1234 commented 6 days ago

@edemuck4timbuktu : Could you please tell us what SAP product has an problem? We have strict downport guidelines to keep running installations stable. Only if there is a real issue with a real application a downpord to older SAPUI5 versions is done.