[FIX] src/sap.ui.core/src/sap/ui/core/IconRenderer: icon is not getting focus from keyboard

[tw4]

Summary of Issue

The icons were not receiving focus when using the keyboard.

Solution

• Updated the code to ensure the icons can be focused using the keyboard.
• Made necessary changes to resolve the issue.

Tests

• Updated the necessary unit tests.
• Added test cases to verify the new functionality and prevent future regressions.

Result

This PR resolves the issue where the icons were not focusable using the keyboard. It includes the necessary changes in unit tests to guarantee the functionality.

Closes #4021

[cla-assistant[bot]]

All committers have signed the CLA.

[codeworrior]

I think this PR contradicts the Icon's API design.

Did you see the following statements in the documentation of sap.ui.core.Icon?

decorative property: A decorative icon is included for design reasons. Accessibility tools will ignore decorative icons. Tab stop isn't affected by this property anymore and it's now controlled by the existence of press event handler and the noTabStop property. press event: ...When a handler is attached to this event, the Icon gets tab stop. If you want to disable this behavior, set the noTabStop property to true.... noTabStop property: Defines whether the tab stop of icon is controlled by the existence of press event handler. When it's set to false, Icon control has tab stop when press event handler is attached. If it's set to true, Icon control never has tab stop no matter whether press event handler exists or not.

[codeworrior]

...bringing this to the attention of @stopcoder

[tw4]

Hello @codeworrior ,

Thank you for your feedback and concerns. After reviewing the documentation, I can confirm that the noTabStop feature is functioning as intended.

Therefore, I plan to close the PR because there is no longer an outstanding issue. Thank you once again for your feedback.

Best regards,