JS Doc for calculateStartDate in SinglePlanningCalendarView

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.

http://openui5.org

Apache License 2.0

2.9k stars 1.23k forks source link

Closed signix closed 1 month ago

signix commented 2 months ago

OpenUI5 version:

The jsdoc of method calculateStartDate in file src/sap.m/src/sap/m/SinglePlanningCalendarView.js does not indicate a return type. Should it include

@return {object} the startDate of the view as we can see in the implementations (SinglePlanningCalendarWorkWeekView, SinglePlanningCalendarWorkWeekView or SinglePlanningCalendarMonthView) ?

Without this the typescript function is expected to return void.

I can add a PR if this is the case.

Thank you

DonkeyCo commented 2 months ago

I've opened an internal incident (DINC0144944) for this problem. The colleagues will have a look and will get back to you

didip1000 commented 1 month ago

Hey @signix,

Thanks for sharing your finding, the issue was fixed with the commit linked above and will be available in UI5 version 1.125.

Best, Diana

signix commented 1 month ago

Thank you for the fix