Dialog Cancel Buttons have Border around them in 1.119 and 1.120

[ac1058]

OpenUI5 version: 1.119, 1.120

Browser/version (+device/version): Chrome

Any other tested browsers/devices(OK/FAIL): N/A

URL (minimal example if possible):

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

1. open the sap.m.Dialog sample in UI5 sample docs
   • click Settings Cog in top right and select 'Belize' and 'Compact'
2. Observe that in 1.119.x and 1.120.x the "Cancel" button has a border around it that did not exist in previous versions and versions >= 1.121.x

• https://sapui5.hana.ondemand.com/1.117.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
• https://sapui5.hana.ondemand.com/1.118.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
• https://sapui5.hana.ondemand.com/1.119.2/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
• https://sapui5.hana.ondemand.com/1.120.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
• https://sapui5.hana.ondemand.com/1.121.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
• https://sapui5.hana.ondemand.com/1.122.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog

What is the expected result?

• Belize Dialog's Cancel button should not have borders around it in 1.119 and 1.120, but previous versions and versions afterwards do not have it

What happens instead?

• Cancel button has borders around it

Any other information? (attach screenshot if possible)

• It appears the css here has been removed Belize Button.less in 1.119 and 1.120

  .sapMIBar-CTX .sapMBtnInner,
  .sapMBar .sapMBtnInner,
  .sapMHeader-CTX .sapMBtnInner,
  .sapMFooter-CTX .sapMBtnInner { 
  background: @sapUiButtonLiteBackground;
  border-color: @sapUiButtonLiteBorderColor;
  }

[DonkeyCo]

Thanks for reporting the issue. I've created an internal incident DINC0148190 for your reported issue. The colleagues will update you once they have news

[stephania87]

sap_belize is deprecated since SAPUI5 1.120: https://openui5nightly.hana.ondemand.com/topic/a87ca843bcee469f82a9072927a7dcdb And the rest of the listed cloud only versions are out of maintenance now https://ui5.sap.com/versionoverview.html Please upgrade and switch to sap_horizon.

Just fyi, the changes are related to new themes development where sap.m.button[type=Default] is not changed when used in specific toolbars: https://github.com/SAP/openui5/commit/ebe17c6c3c054a4922e02a4dfc896d6ef4592c49

[stephania87]

PS: when you create toolbars with buttons, consider setting Toolbar.design and Button.type based on https://experience.sap.com/fiori-design-web/toolbar-overview/#header-and-footer-toolbars1 As for demos, there are already logged internal tasks for reviewing the settings in the DemoKit with consideration of Fiori Guidelines