SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.9k stars 1.23k forks source link

sap.m.Popover header border misaligned in light themes #4060

Closed bfopta closed 1 month ago

bfopta commented 1 month ago

OpenUI5 version: 1.124, but older versions are also affected

Browser/version (+device/version): latest firefox, chrome

Any other tested browsers/devices(OK/FAIL): -

URL (minimal example if possible): sample

User/password (if required and possible - do not post any confidential information here): -

Steps to reproduce the problem:

  1. Open the sample for edit
  2. Replace the content of view/Popover.fragment.xml with the following code:
    <core:FragmentDefinition
    xmlns="sap.m"
    xmlns:core="sap.ui.core"
    xmlns:l="sap.ui.layout">
    <Popover>
        <customHeader>
            <l:VerticalLayout 
                width="10rem"
            >
            </l:VerticalLayout>
        </customHeader>
    </Popover>
    </core:FragmentDefinition>
  3. Click on the Show Popover button

What is the expected result? It should display a popover with the gray line inside the popover.

What happens instead? The gray line is rendered outside of the popover.

Any other information? (attach screenshot if possible)

image

Affects both Quartz Light and Morning Horizon themes.

niyap commented 1 month ago

Hello @bfopta,

Thank you for sharing this finding. I've created an internal incident DINC0173393. The status of the issue will be updated here in GitHub.

Regards, Niya

TeodorTaushanov commented 1 month ago

Hi,

Instead of Horizontal/VerticalLayout, you can use HBox/VBox like here:

<core:FragmentDefinition
    xmlns="sap.m"
    xmlns:core="sap.ui.core"
    xmlns:l="sap.ui.layout">
    <Popover>
        <customHeader>
            <VBox 
                width="10rem"
            >
               <Text text="text" /> 
            </VBox>
        </customHeader>
    </Popover>
</core:FragmentDefinition>

Best, Teo