JsDoc: QuickView.openBy incomplete parameter documentation / generated TypeScript type

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.

http://openui5.org

Apache License 2.0

2.95k stars 1.24k forks source link

JsDoc: QuickView.openBy incomplete parameter documentation / generated TypeScript type #4063

Closed heimwege closed 3 months ago

heimwege commented 3 months ago

Hey hey 👋🏻

the Js doc parameter type for the QuickView.openBy function is incomplete. According to Js doc it's sap.ui.core.Control but having a look at the ResponsivePopover that is being called within that function it's actually sap.ui.core.Control|HTMLElement. Hence the generated TypeScript type complains although everything works fine in case you use an HTMLElement.

TeodorTaushanov commented 3 months ago

Hello,

Thank you for sharing this finding. I've created an internal incident DINC0180755. The status of the issue will be updated here in GitHub.

Regards, Teo

TeodorTaushanov commented 3 months ago

This issue is fixed in the master branch.