search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.9k stars 1.23k forks source link

sap.m.DynamicDateRange: format implementation generates error logs for missing operators. #4077

Closed sukramAxians closed 4 days ago

sukramAxians commented 1 week ago

OpenUI5 version: 1.120.15, 1.124.0

Browser/version (+device/version): Chrome latest

Any other tested browsers/devices(OK/FAIL): No

URL (minimal example if possible): https://sapui5.hana.ondemand.com/#/entity/sap.m.DynamicDateRange/sample/sap.m.sample.DynamicDateRangeWithCustomOptions

Steps to reproduce the problem:

  1. Open Link
  2. Open Developer Tools (Console)
  3. Press Input to open up DynamicDateRange image

What is the expected result? No Spam in console.

What happens instead? Console is full of errors. Errors are logged for each open up of popover. image

Any other information? (attach screenshot if possible)

https://github.com/SAP/openui5/blob/747ece9dfd19abf198d0f8258619faf1415b75db/src/sap.m/src/sap/m/DynamicDateFormat.js#L256 This line seems to be responsible for the issue, because THISWEEK is not handled in following lines.

https://github.com/SAP/openui5/blob/747ece9dfd19abf198d0f8258619faf1415b75db/src/sap.m/src/sap/m/DynamicDateFormat.js#L196-L225

ResourceBundle#_formatValue expects aArgs to be an Array. image

Kind Regards Markus

flovogt commented 1 week ago

Thanks a lot @sukramAxians for reporting this issue. I have created an internal incident DINC0194230 and the respective team will update the status of the issue here in GitHub.

tsanislavgatev commented 4 days ago

Hi @sukramAxians ,

The issue was fixed with the following commit: https://github.com/SAP/openui5/commit/25ffdcd6625262bd41e0e0b0ccf92a0b2ca48c83

Best Regards, Tsanislav