search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.9k stars 1.23k forks source link

Busy property doesn't work for sap.m.ColumnListItem #4081

Closed yurakovay closed 1 week ago

yurakovay commented 1 week ago

OpenUI5 version: 1.124.0 Browser/version (+device/version): Google Chrome Version 126.0.6478.126 Any other tested browsers/devices(OK/FAIL): on Misrosoft Edge the same

URL (minimal example if possible): https://sapui5.hana.ondemand.com/sdk/#/entity/sap.m.ColumnListItem/sample/sap.m.sample.Table User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Open example of sap.m.Table
  2. Try to set busy="true" for ColumnListItem

What is the expected result? Busy indicator for table row What happens instead? Nothing Any other information? (attach screenshot if possible) image

flovogt commented 1 week ago

Thanks a lot @yurakovay for reporting this issue. I have created an internal incident DINC0194778 and the respective team will update the status of the issue here in GitHub.

boghyon commented 1 week ago

@yurakovay

The issue was addressed at https://github.com/SAP/openui5/issues/2041. Unfortunately:

this is a known limitation as you already see the console message. we do not support busy for the ColumnListItem.

yurakovay commented 1 week ago

@boghyon why you have this property in documentation? image

boghyon commented 1 week ago

@yurakovay The quote is from the linked issue.

@aborjinik It would be great if the current limitation wrt busy in list items could be reconsidered. If the limitation is supposed to be kept, the busy description in the unsupported items could be adjusted accordingly. (See https://github.com/SAP/openui5/issues/4081#issuecomment-2194830243)

FelixSchubert-001 commented 1 week ago

Hello @yurakovay, the setBusy method is borrowed from sap.ui.core.Control where it is stated "Note: The busy state can't be set on controls (e.g. sap.m.ColumnListItem) which renderings have the following tags as DOM root element: area|base|br|col|embed|hr|img|input|keygen|link|menuitem|meta|param|source|track|wbr|tr" which is also why this property is not longer mentioned in the latest version of the sap.m.ColumnListItem documentation.