search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.97k stars 1.24k forks source link

make DynamicDateRange.js control available in forms #4130

Open stesap opened 2 months ago

stesap commented 2 months ago

Change

This change will add support for forms (sap.ui.layout.form.Form) and form container (sap.ui.layout.form.FormContainer) on DynamicDateRange control.

Motivation

The DynamicDateRange control is shown in the UI5 samples page mostly as a filter for a table. It would also be helpful to have this input control in a form as well. At least we tested this successfully in our app and haven't seen any issues so far.

cla-assistant[bot] commented 2 months ago

CLA assistant check
All committers have signed the CLA.

MapTo0 commented 2 months ago

Hello @stesap ,

Thank you for your pull request. I've created an internal record DINC0279997. The status of the issue will be updated here in GitHub.

Regards, Martin

DMihaylova commented 2 months ago

Hi @stesap,

Could you please share your scenario? Dynamic Date Range could have different value types (e.g. "Yesterday", single date, date range, from/to, etc) which makes it impossible for binding. How you plan to format it after the form validation?

Thanks & Regards, Diana

stesap commented 1 month ago

Hi @DMihaylova, in our app we're using the control to provide relative dates:

In addition as we use these values as a relative date in the database, to create schedules for automated runs in the future. Therefore we find it inconvenient for the user, to display a certain date in brackets (see method DynamicDateRange.prototype._enhanceInputValue), which is misleading for our schedule. And the option for last day of previous month is not available.

To support the binding, we implemented a custom type, which does the parsing and formatting. Maybe, it's possible to support these via interfaces and methods which needs to be implemented by developers? Similar to the sap.m.DynamicDateOption where custom options need to implement format/parse/validate methods?

-Steffen