search

SAP / openui5

OpenUI5 lets you build enterprise-ready web applications, responsive to all devices, running on almost any browser of your choice.
http://openui5.org
Apache License 2.0
2.97k stars 1.24k forks source link

Right click fires other events #4157

Closed harelyshau closed 2 weeks ago

harelyshau commented 1 month ago

This is copy of this issue: https://github.com/SAP/openui5/issues/3936 and https://github.com/SAP/openui5/issues/3973 as I didn't get any response there. Might be helpful to read it initially.

OpenUI5 version: latest (1.129.0)

Browser/version (+device/version): Chrome, Firefox, Safari (all on MacOS)

URL (minimal example if possible): https://harelyshau.dev/#/games/minesweeper (most priority for me) https://openui5.hana.ondemand.com/entity/sap.m.IconTabBar/sample/sap.m.sample.IconTabBar https://openui5.hana.ondemand.com/entity/sap.tnt.ToolHeader/sample/sap.tnt.sample.ToolHeaderIconTabHeader

Steps to reproduce the problem:

For custom button: 1) Go to this link: https://harelyshau.dev/#/minesweeper 2) Left click to any cell image 3) Right click to any closed cell image 4) Again right to cell which is clicked on step 3 image a result left click (press event) is also fired. But I think shouldn't be

For IconTab:

Click right button to one of the following controls: IconTabFilter (1st link) IconTabHeader (2nd link) I'm using right click and left click with pressed ctrl button (should be the same result, but might be different) Left Click to empty space And you will see that time to time events like select or liveChange are triggered by this scenario Video link: https://1drv.ms/v/s!AhK9R225yn15a94Enfuo3KDccoI?e=VvVR2Q What is the expected result? Just open context menu without triggering extra events What happens instead? Context menu is opened but with extra triggering of events

Any other information? (attach screenshot if possible) I've found that when I implemented custom button this way (just add one more event for handling right click). And I found that right click also triggers simple press event in button. I didn't expect that and tried with default button and there I wasn't be able to reproduce it and found other controls which have similar issue. Seems it's not all controls which have this behaviour but it's what I found quickly image

Video link: https://1drv.ms/v/s!AhK9R225yn15a94Enfuo3KDccoI?e=VvVR2Q

didip1000 commented 2 weeks ago

Hey @harelyshau,

ontouchend had two sections where it could fire a press event, the first check was fixed but the second check would also fire. It should be fixed now with the commit above, and will be available in version 1.131.

Best,