sap.ui.ux3.Feeder

[wuytsrobbe]

Hi,

I know this control is experimental, but here is the issue I found:

When using the Feeder control on an iOS Device, the return (new line) function doesn't work. A new line is created, but the cursor remains on the same line.

I tested both in safari and chrome, both had the same result.

The devices I used for testing are:

• iPad mini
• iPad 4
• iPhone 4S

Kind regards,

Robbe Wuyts

[matz3]

Hi Robbe,

I tested this with a iPhone 5s (iOS 7.1.2) using this page (version 1.22.4): https://openui5.hana.ondemand.com/test-resources/sap/ui/ux3/Feeder.html

Everything worked fine there. Which iOS / OpenUI5 version did you use?

Best regards, Matthias

[wuytsrobbe]

Hi Matthias,

I used an iPhone 4S. The open UI5 version is 1.18.12.

Kind regards,

Robbe Wuyts SAP NetWeaver/CRM Consultant

T +32 15 29 58 58 M +32 494 28 51 68 @ robbe.wuyts@ordina.bemailto:robbe.wuyts@ordina.be

[ordina_mail_logo]

From: Matthias Oßwald [mailto:notifications@github.com] Sent: vrijdag 1 augustus 2014 14:30 To: SAP/openui5 Cc: Wuyts, Robbe Subject: Re: [openui5] sap.ui.ux3.Feeder (#97)

Hi Robbe,

I tested this with a iPhone 5s (iOS 7.1.2) using this page (version 1.22.4): https://openui5.hana.ondemand.com/test-resources/sap/ui/ux3/Feeder.html

Everything worked fine there. Which iOS / OpenUI5 version did you use?

Best regards, Matthias

— Reply to this email directly or view it on GitHubhttps://github.com/SAP/openui5/issues/97#issuecomment-50878584.

[wuytsrobbe]

Hi,

I noticed the problem lays within the bluecrystal theme. When I use e.g. goldreflection, the problem is solved.

Regards,

Robbe Wuyts

[akudev]

Hi, at least on my test iPhone 4S with iOS 5.0.1 this is indeed an issue, and as Robbe said only in Blue Crystal, not in base theme.

I forwarded this internally as 0120061532 0001398668 2014.

Thanks and regards Andreas

[wuytsrobbe]

Hi, Has there been any progress on this issue? Kind regards, Robbe

[akudev]

No. After all it's only confirmed since three days and it is vacation time and the next patch is anyway two weeks away.. Somebody is assigned internally, but no fix completed yet. But your input for a suggested fix is highly welcome. ;-)

Andreas

[wuytsrobbe]

Well, I hope the fix will be included in that patch... Sorry for asking again, but do you know if there has been any progress on this issue?

[akudev]

Doesn't look like it will. Please note that OpenUI5 comes for free, but also without warranty or service level agreements. You are welcome to debug the issue and propose a solution. This would speed up the handling of this issue.

Regards Andreas

[Suzanne99]

Hello,

Can you give any indication about when this topic can be solved ?

We have no workaround available so we are blocked. We can't go live with our application before this is solved.

Kind regards Suzanne

[wuytsrobbe]

Andreaz,

I debugged the Feeder control and I found this:

The generated html has some differences:

SAP_BLUECRYSTAL:

<"/div" id="Feeder" data-sap-ui="Feeder" class=".sapUiFeederLarge>.sapUiFeederInput.test sapUiFeeder sapUiFeederLarge">

<"/div">id="Feeder-input" contenteditable="true" class="sapUiFeederInput"> <"/div">First line<"/div"> <"/div">Second line<"/div"> <"/div">Third line<"/div"> <"/div">

SAP_GOLDREFLECTION

<di*v id="Feeder" data-sap-ui="Feeder" class=".sapUiFeederLarge>.sapUiFeederInput.test sapUiFeeder sapUiFeederLarge">

<di*v id="Feeder-input" contenteditable="true" class="sapUiFeederInput"> First line <"/div">Second line<"/div"> <"/div">Third line<"/div"> <"/div">

Notice the difference in the <"/div"> tags.

Another thing I noticed: If you add this in the css, the problem is solved: .sapUiFeederLarge>.sapUiFeederInput { display: inline-block; }

Now each line will be surrounded by
tags, instead of

tags, so this has to be catched in the sap.ui.ux3.Feeder.prototype.getMultilineText function in the source files (otherwise you get a concatenation of all the lines).

BUT: If you do this, the feeder control looks messed up! So additional styling is neccesary (which I didn't figured yet :) )

I hope this can help...

Regards,

Robbe Wuyts

[akudev]

Hi,

the last comment unfortunately looks somehow broken/incomplete, but the good news is that there has been a fix done on the master branch today. Will also be applied to 1.22 and 1.24, but it won't make the 1.22 patch, which is being built now, so the fix will be in 1.22.* in about two weeks from now.

The fix looks a bit different, adding the following CSS rule: html.sap-phone [contenteditable=true] > div, html.sap-tablet [contenteditable=true] > div { -webkit-user-select: text; -moz-user-select: text; -ms-user-select: text; user-select: text; }

Whoever feels comfortable applying this locally, can do it as a temporary workaround. Whoever wonders how to do it, should probably rather wait for the fix.

Regards Andreas

[wuytsrobbe]

Hi,

I just tested the local css fix, and there are still some problems using:

• apple iPad4 - safari
• apple iPhone 4S - chrome

Anyways, it will work on most devices/browsers now.

Kind regards, Robbe

[akudev]

Hi Robbe,

I verified the fix works on

• iPhone 4S with iOS 5.0.1
• iPad mini with iOS 7.1.1 These are like the most extreme versions and different devices we have.

(both in Safari, note that we do not officially support Chrome on Apple devices, but since Chrome uses the Apple WebView, the behavior should be the same.)

The fix will be in 1.22.9 and at the moment I'd assume that it works, so I'm closing this ticket. If you still can reproduce it in 1.22.9+, please specify the exact iOS version where you saw it.

Thanks and regards Andreas