Add option to specify a github-token to avoid rate-limit

SAP / project-piper-action

CI/CD tooling for the SAP Ecosystem, integrated with GitHub Actions

38 stars 15 forks source link

Add option to specify a github-token to avoid rate-limit #177

Closed maginseb closed 6 months ago

maginseb commented 6 months ago

Hi, I hope it is okay for me to just open a pull request with a proposal. I'm running this action on a GitHub Enterprise machine. The problem that I'm facing is that ~50% of the times the request to check for the latest version of Piper gets rejected by GitHub due to rate-limiting. I found that if I authenticate to github.com I could work around this rate-limit and not run into the issue.

cla-assistant[bot] commented 6 months ago

All committers have signed the CLA.

maginseb commented 6 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

~~It seems that I can't sign the CLA unfortunately. The bot sends me to an empty page.~~

Today it worked

CCFenner commented 6 months ago

Thanks for the PR, unfortunately this action (master branch) is deprecated and we're working on the main branch. ~~Can you switch to target that branch?~~ I switched the branches myself.

CCFenner commented 6 months ago

@maginseb can you resolve the conflict?

maginseb commented 6 months ago

@CCFenner My mistake. I found that what I was trying to implement already exists in the main branch. Sorry for my mistake, I didn't realise that the master branch was heavily outdated.

For everyone who sees this and is currently facing the issue of 403s on GitHub Enterprise:

Be sure to hand over an access token to github.com using the input github-token. This will prevent you from running into the rate-limit.