search

SAP / project-portal-for-innersource

Lists all InnerSource projects of a company in an interactive and easy to use way. Can be used as a template for implementing the "InnerSource portal" pattern by the InnerSource Commons community.
https://sap.github.io/project-portal-for-innersource/
Apache License 2.0
143 stars 71 forks source link

Remove tracked dependencies #24

Open dellagustin opened 3 years ago

dellagustin commented 3 years ago

Dependencies were being tracked despite the .gitignore and the postinstall script.

With this PR, the tracked dependencies are removed. The .gitignore rules were updated to ignore everything in the lib folder except for the README.md file.

spier commented 3 years ago

Great find!

Do you have any suspicions why the .gitignore file didn't work as expected? Just curious.

dellagustin commented 3 years ago

Hi @spier, I suspect that the .gitignore rule was added after the files were already tracked (that could be verified on the history, but I did not went that far).

Michadelic commented 3 years ago

Hi @dellagustin, these files are checked in intentionally as we do not have a build step for gh_pages currently. While they are not needed for a local setup (postinstall step is taking care of it) this would break the online demo. It could be achieved by setting up a travis job however.