phanak-sap
commented
12 months ago Hi @anthonyng288
thanks for the bug report. Clearly the existing test suite did not catch this problem. Yes, breaking change has the utmost priority.
Could you please provide me the $metatada for the service, or just snippet relevant to CustomerCollection? Or ideally, failing unit test (PR here) or a bug reproducer script - e.g PR for https://github.com/phanak-sap/pyodata-issue-files
The provided code
customers = accountService.entity_sets.CustomerCollection.get_entities().count(inline=True).filter("LifeCycleStatusCode eq '2'").custom("$orderby", "LastChangeDateTime desc").custom("$top", "8").execute()
is only half of the root cause, I am only guessing what is on the other side this code is going trough. I can guess, but then - how can I be sure it is really the problem you are seeing.
anthonyng288
manuelseeger
ksaito1125
After updating to PyOData version 1.11.0, I encountered a significant issue with a previously functional query. The purpose of the query is to retrieve a list of customers using the CustomerCollection.get_entities() method, with additional parameters for counting, filtering, ordering, and limiting the number of results.
Issue Details: The following Python code, which worked flawlessly in version 1.10.1, started throwing an AttributeError in version 1.11.0:
customers = accountService.entity_sets.CustomerCollection.get_entities().count(inline=True).filter("LifeCycleStatusCode eq '2'").custom("$orderby", "LastChangeDateTime desc").custom("$top", "8").execute()Error Message: The error message received is as follows:[ERROR] AttributeError: 'str' object has no attribute 'get' Traceback (most recent call last): File "/var/task/GETAccountandContact.py", line 86, in lambda_handler customers = accountService.entity_sets.CustomerCollection.get_entities().count(inline=True).filter("LifeCycleStatusCode eq '2'").custom("$orderby", "LastChangeDateTime desc").custom("$top", "8").execute() File "/tmp/pyodata/v2/service.py", line 349, in execute return self._call_handler(response) File "/tmp/pyodata/v2/service.py", line 362, in _call_handler return self._handler(response) File "/tmp/pyodata/v2/service.py", line 1549, in get_entities_handler entity = EntityProxy(self._service, self._entity_set, self._entity_set.entity_type, props) File "/tmp/pyodata/v2/service.py", line 881, in __init__ self._cache[prop.name].append(EntityProxy(service, None, prop_etype, entity)) File "/tmp/pyodata/v2/service.py", line 825, in __init__ etag_body = proprties.get('__metadata', dict()).get('etag', None)Temporary Solution: As a temporary workaround, I had to downgrade to version 1.10.1, after which the query started working again without any errors.
Request: I believe this is a bug introduced in version 1.11.0. It would be greatly appreciated if the team could investigate this issue and provide a fix or guidance on how to resolve it in the newer version of PyOData.
Thank you for your attention to this matter.