search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Fix major bug sonar violations #1006

Closed Xymmer closed 5 years ago

Xymmer commented 5 years ago

See https://sonarcloud.io/project/issues?id=sap_cloud-commerce-spartacus-storefront&resolved=false&severities=MAJOR&types=BUG

Break down into separate issues if it makes sense.

kacperknapik commented 5 years ago

please fix the unit tests before review can be done @Pucek9

Pucek9 commented 5 years ago

https://sonarcloud.io/project/issues?id=sap_cloud-commerce-spartacus-storefront&pullRequest=1020&resolved=false