search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Fix critical code smell sonar violations #1008

Closed Xymmer closed 5 years ago

Xymmer commented 5 years ago

See https://sonarcloud.io/project/issues?id=sap_cloud-commerce-spartacus-storefront&resolved=false&severities=CRITICAL&types=CODE_SMELL

Break this one down into smaller tasks or new tickets if it helps spread the love around :)

Pucek9 commented 5 years ago

Critical smells are done: https://sonarcloud.io/project/issues?id=sap_cloud-commerce-spartacus-storefront&pullRequest=1053&resolved=false

Unfortunately changes provided one new major code smell, but it doesn't applicable this ticket

kacperknapik commented 5 years ago

sonar errors must be fixed before merging

Pucek9 commented 5 years ago

sonar errors must be fixed before merging

@kacperknapik That PR doesn't touch Major Code Smells, for that will be new ticket if @Xymmer decide