use method "GET" to get a list of cms components (instead of POST)

[WeizhengSap]

Before, we use POST method, and put the list of cms component ids in request body. Smartedit team change the API, so in SPA, we also need to change the function.

For details, please check this: https://jira.hybris.com/browse/CMSX-8193

Changed in their M14 release

[WeizhengSap]

Using GET, component ids are appended into URL. If the URL length exceeds the limit, we have to use pagination to split the list of ids into several lists.

[Xymmer]

i've asked Tobias if we should build in a 2000-url limit into our function

[bgambocjaviniar]

PR GH-2430

[hackergil]

From @bgambocjaviniar:

NOT ABLE TO MERGE YET ---> Because it will break the develop branch

To be able to get a response, do the following:

• point your environment to https://dev-com-2.accdemo.b2c.ydev.hybris.com:9002

Note our current environment do not have the new GET endpoint to get components by ids. These changes were released in wcms-module-19.05.0-M13

[Xymmer]

Now we have to do this for 1.0 launch as there is a problem with footer nav nodes HOWEVER can we set a flag to use one or the other, so 1811 still works? or we do a test if POST works and then fall back to GET? Check with Tobias on strategy.

[Xymmer]

this problem only affects when using smartedit.

but we still need to support both for a while.

talk to tobias about optimum solution.

options:

1. at run time we detect that get doesn't work, and try post.
2. there is a flag that tells our app to use post (default to get though).

[bgambocjaviniar]

UPDATE:

• Do a GET (since we want to support the latest and greatest one)
• If GET does not exist, do a POST

First of all, need to check what kind of error it will throw if one of them does not work and handle it to use the latter.

[bgambocjaviniar]

PR: GH-2430

[bgambocjaviniar]

For the QA:

• Go to dev tools on any page like homepage, click the network, and verify it uses the GET endpoint for components
• To test that the fallback works, you can go to occ-cms-component.adapter, and swap the .get and .post and bring the request['componentIds'] = ids.toString() in the get function to the post function. -- > Reason being is that I don't think the call will ever fail for the get endpoint, therefore test the post endpoint by giving an invalid body.

[RadhepS]

There is an issue where when the GET request fails, the POST request for components is sent twice.

Originally posted by @RadhepS in https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/2430#issuecomment-493567361

[bgambocjaviniar]

This will be fix in another ticket GH-2589 on Radhep's comment