search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
737 stars 381 forks source link

Lack of Support for Product Config (Variant Config) in Schematics Deployment Script #10385

Open giancorderoortiz opened 3 years ago

giancorderoortiz commented 3 years ago

Steps to Reproduce:

  1. Clone Spartacus github repository.
  2. Navigate to scripts/install and copy config.default.sh into config.sh.
  3. Modify config.sh as needed. Make sure epic/product-configuration is setup as branch and b2b flag is disabled.
  4. Execute ./run.sh install command.
  5. Execute ./run.sh start command

Expected Results:

  1. Product configuration feature is enabled in B2C storefront.

Actual Results:

  1. Product configuration feature is not enabled. Upon further inspection, the product config flag is not present in environment.ts

(It appears that there is no support for this feature with schematics installation script)

environment.ts file when deploying via yarn: Screen Shot 2020-12-11 at 1 03 39 PM

Config file used with schematics script Screen Shot 2020-12-11 at 12 56 46 PM

Environment.ts file generated: Screen Shot 2020-12-11 at 12 56 35 PM

Platonn commented 3 years ago

The support of product configurator lib was added in the installation script: https://github.com/SAP/spartacus/commit/02091730e43dc60c606d1025516f44566d8df6eb#diff-12e10006539534b8b2bb09a714ec4739f05257082d82c8c277ba80ea5e1360a5

@giancorderoortiz Could you double check if it works for you and close the ticket?

giancorderoortiz commented 3 years ago

develop branch or a specific release version?